Closed dandelany closed 3 weeks ago
@lklyne @dandelany Is there a design for this? Showing the error immediately after upload is easy enough, but currently the users can still see that uploaded model if they go to the model list page. I feel like we should at the very least show that error maybe in the models table in a column or something. But it also feels weird that we even show that model at all in the table if it's not something that the user can use. Can we filter out any models with errors from the table if it's not useful to show them?
@lklyne @dandelany Is there a design for this? Showing the error immediately after upload is easy enough, but currently the users can still see that uploaded model if they go to the model list page. I feel like we should at the very least show that error maybe in the models table in a column or something. But it also feels weird that we even show that model at all in the table if it's not something that the user can use. Can we filter out any models with errors from the table if it's not useful to show them?
A few potential approaches top of mind:
Background
Original backend ticket: https://github.com/NASA-AMMOS/aerie/issues/1273
Users have run into a situations where an error occured when Aerie processed the mission model jar, but no error appeared to the user. Fixing this is a bit more difficult than just displaying an HTTP response, because the upload & subsequent processing happen asynchronously, so there is some delay between the initial request & the error.
@Mythicaeda has implemented an events view in the Hasura API to allow us to get any errors that occur into the frontend, see implementation details here: https://github.com/NASA-AMMOS/aerie/pull/1418
Requirements
Tagging @parkerabercrombie for visibility..
Design direction: https://www.figma.com/design/gWEDKg40Uv0EUvEB9BVmGZ/Model-Spec-Error-Handling?node-id=19-18496&t=hw9Sf1BK9kROvi2T-4
extracting...
andextraction failed
if presentextracting
andextraction errors
jar file status
line to details and show callouts for statesextracting
andextraction errors
by model select dropdownextraction errors
icon next to model name if there are errors