Closed AaronPlave closed 1 month ago
When a span is selected, the timeline doesn't scroll to bring the selected span into focus, which is not the current behavior on develop. However, this branch makes it easier to select specific spans, but also harder to find the one you selected on the timeline. Would it be possible to scroll and highlight the ancestors of a selected span?
Moving to a separate effort after some discussion.
@duranb resolved all of your comments, let me know if there are any other changes you'd like to see.
Improves performance and usability of activity layers on the timeline. Benchmarking against Clipper cruise plan (thousands of directives and spans) and Endurance sim (< 10 directives, 250k+ spans).
Closes #593, closes #1023, closes #600, closes #613, closes(?) #1004, closes(?) #669, partially addresses #459, partially addresses #1140, partially addresses #1169
Implements:
activityDirectivesByView
store and refactored code to dynamically grab directives when needed to avoid unnecessary re-rendering of activity timeline when unrelated parts of the view changedactivityDirectivesList
using the plan and spans as inputgetSpans
TODO:
Future?