search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 4 forks source link

Sequence preview lints with wrong parcel #1270

Closed cartermak closed 1 month ago

cartermak commented 1 month ago

Checked for duplicates

Yes - I've already checked

Is this a regression?

No - This is a new bug

Version

v2.6.104

Describe the bug

When previewing a sequence on the "Sequences" page, the linter runs using the last loaded parcel (i.e., the parcel selected for the last sequence which was opened). We should either load the correct parcel for the selected sequence, or not lint in the preview.

Reproduction

  1. Create two parcels that differ in one or more ways.
  2. Write a "Sequence 1" which is valid according to dictionaries/adaptation in Parcel A, but not in Parcel B. Save it with Parcel A selected.
  3. Edit a "Sequence 2" with Parcel B. Save that sequence and return to the "Sequencing" page.
  4. Select (but don't open) "Sequence 1". Expect that the SeqN preview window shows linting against Parcel B, even though the sequence is saved with Parcel A.

Logs

No response

System Info

Firefox on MacOS

Severity

Minor

joswig commented 1 month ago

Fixed with dictionary caching work