NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 4 forks source link

Phoenix SeqJSON ingest quotes symbol arguments #1299

Closed cartermak closed 1 month ago

cartermak commented 1 month ago

Checked for duplicates

Yes - I've already checked

Is this a regression?

No - This is a new bug

Version

2.11.0

Describe the bug

Symbol arguments in SeqJSON are expressed as the unquoted symbol name in SeqN. Currently, when uploading a SeqJSON with symbol arguments, the generated SeqN has the symbol names quoted, which is wrong and generates an incorrect SeqJSON.

Reproduction

Given a SeqJSON command:

        {
            "type": "command",
            "stem": "MY_COMMAND_STEM",
            "time": {
                "type": "COMMAND_COMPLETE"
            },
            "args": [
                {
                    "type": "symbol",
                    "value": "L00INT"
                },
                {
                    "type": "symbol",
                    "value": "L01INT"
                }
            ]
        }

The generated SeqN should be:

C MY_COMMAND_STEM L00INT L01INT

...but instead, it's currently:

C MY_COMMAND_STEM "L00INT" "L01INT"

...which is then written out as this incorrect SeqJSON:

    {
      "args": [
        {
          "type": "string",
          "value": "L00INT",
          "name": "arg_one"
        },
        {
          "type": "string",
          "value": "L01INT",
          "name": "arg_two"
        }
      ],
      "stem": "MY_COMMAND_STEM",
      "time": {
        "type": "COMMAND_COMPLETE"
      },
      "type": "command"
    }

Logs

No response

System Info

Aerie 2.11.0 run locally; Firefox on MacOS

Severity

Major