NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 4 forks source link

"View Merge Request" button appearing on plan that isn't involved in the Active Merge RQ #1308

Open Mythicaeda opened 1 month ago

Mythicaeda commented 1 month ago

Checked for duplicates

No - I haven't checked

Is this a regression?

Yes - This worked in a previous version

Version

develop

Describe the bug

Current visible on aerie-dev. There's an open merge request to merge changes from Plan 130 into Plan 110, but the "View Merge Request" button is appearing on Plan 128 (which is a sibling Plan of Plan 130). Note that Plan 130 correctly displays this button, and that this button correctly navigates to Plan 110's active merge rq regardless of which plan you click it from.

image

Minor, but additionally the button appears to not be properly resizing (note that the first image is with my browser at max width).

image

Reproduction

  1. Create a plan
  2. Create two sibling branches of that plan.
  3. Modify one of the sibling branches and create a merge rq from it to the parent
  4. Open the parent and begin a review of that rq
  5. Without closing the merge rq, navigate to the other sibling branch.

The button will be visible on that branch.

Logs

No logs were produced

System Info

Mac OS, Firefox

Severity

Minor