search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 4 forks source link

Phoenix malforms SeqJSON for relative time tags with DOY field #1316

Closed cartermak closed 2 weeks ago

cartermak commented 4 weeks ago

Checked for duplicates

Yes - I've already checked

Is this a regression?

No - This is a new bug

Version

2.11.0

Describe the bug

The SeqJSON generated by Phoenix is malformed when using a relative time tag with the DOY field.

Seems to be from this: https://github.com/NASA-AMMOS/aerie-ui/blob/b8ea05ce1b330ce55775bea4dec12f8020cdbab0/src/utilities/new-sequence-editor/to-seq-json.ts#L274-L281

Reproduction

Author a SeqN command using the DOY field for a command-relative time tag:

R001T00:00:01 CMD_NO_OP

The generated SeqJSON repeats the <DOY>T component:

    {
      "args": [],
      "stem": "CMD_NO_OP",
      "time": {
        "tag": "001T001T00:00:01",
        "type": "COMMAND_RELATIVE"
      },
      "type": "command"
    },

Logs

No response

System Info

N/A

Severity

Major