NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 4 forks source link

Phoenix adds escaped quotes to metadata keys #1334

Closed cartermak closed 2 weeks ago

cartermak commented 2 weeks ago

Checked for duplicates

Yes - I've already checked

Is this a regression?

Yes - This worked in a previous version

Version

rc-v2.11.1

Describe the bug

When using the @METADATA directive, the key now incorrectly gets escaped quotes. This was introduced on the rc-v2.11.1 branch.

Reproduction

Write SeqN which uses the @METADATA directive:

@ID "my_sequence"
@METADATA "this_is_my_key" "This is the value"

C CMD_NO_OP

The generated SeqJSON should be:

{
  "id": "my_sequence",
  "metadata": {
    "this_is_my_key": "This is the value"
  },
  "steps": [
    {
      "args": [],
      "stem": "CMD_NO_OP",
      "time": {
        "type": "COMMAND_COMPLETE"
      },
      "type": "command"
    }
  ]
}

...but it's currently:

{
  "id": "my_sequence",
  "metadata": {
    "\"this_is_my_key\"": "This is the value"
  },
  "steps": [
    {
      "args": [],
      "stem": "CMD_NO_OP",
      "time": {
        "type": "COMMAND_COMPLETE"
      },
      "type": "command"
    }
  ]
}

Logs

No response

System Info

Firefox on MacOS, local deployment of `rc-v2.11.1` branches of Aerie core + Aerie UI.

Severity

Major

dandelany commented 2 weeks ago

Thanks for the report @cartermak - @goetzrrGit is looking into it.