search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
29 stars 6 forks source link

Phoenix: Allow inline comments on directives? #1408

Open cartermak opened 3 months ago

cartermak commented 3 months ago

Checked for duplicates

No - I haven't checked

Alternatives considered

No - I haven't considered

Related problems

No response

Describe the feature request

We allowed inline comments in our SeqN command-line tools anywhere, including on directive lines. Posing this more as a question than a request since it might've been an intentional design decision -- is there a reason inline comments aren't allowed in the grammar on non-command lines?

joswig commented 2 months ago

They were disallowed primarily due to not having a spot to store them in the current seq.json schema. We may be moving away from seq.json round-trip-ability as being a driver since we are storing both formats, and in the process of adding support for other formats