search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
29 stars 6 forks source link

Seqn Format: Make input arg and local variable definition match and allow one input arg/local variable definition per line #1460

Closed shaheerk94 closed 2 weeks ago

shaheerk94 commented 1 month ago

Checked for duplicates

Yes - I have checked

Alternatives considered

Yes - I have considered

Related problems

Sequences can have many input arguments and local variables. Allowing one def/line would make this a lot more readable. Also, the syntax is different for the two formats, which is also a little less readable.

Screenshot 2024-09-11 at 8 41 24 AM

Describe the feature request

Propose allowing the following:

@START_INPUT_PARAMS burn_timeout { "TYPE": "FLOAT", "RANGE": "135.0...2500.0" } close_lv { "TYPE": "STRING", "ENUM_NAME": "YES_NO" } minimum_momentum_delta { "TYPE": "FLOAT", "RANGE": "0.1...35.0" } momentum_bound { "TYPE": "FLOAT", "RANGE": "0.0...35.0" } slew_duration { "TYPE": "UNSIGNED_DECIMAL", "RANGE": "0...3600" } @END_INPUT_PARAMS

@START_LOCALS burn_timeout { "TYPE": "FLOAT"} close_lv { "TYPE": "STRING"} minimum_momentum_delta { "TYPE": "FLOAT" } momentum_bound { "TYPE": "FLOAT" } slew_duration { "TYPE": "UNSIGNED_DECIMAL" } @END_LOCALS

shaheerk94 commented 1 month ago

Note: Do not merge any grammar changes before Phoenix demos during the week of 9/23

shaheerk94 commented 1 month ago

Question: do we need the brackets and quotes around the variable definitions? If we're doing one declaration per line, what about something like: 

burn_timeout FLOAT [135.0-2500.0][
close_lv { "TYPE": "STRING", "ENUM_NAME": "YES_NO" } <-- not sure how we might handle this one
minimum_momentum_delta FLOAT 0.1-35.0
momentum_bound FLOAT 0.0-35.0
slew_duration UNSIGNED_DECIMAL 0-3600
@END_INPUT_PARAMS