shaheerk94
commented
5 days ago Notes from 10/16 tagup:
- Should it be a warning when you call a subroutine that doesn't exist from a sequence? It needs to be okay to call things that the editor isn't aware of (next master sequence for MSL, SPAM scripts)
- Should eventually have a way to open up the referenced subroutines (stretch goal, would require adding multi-tab to the editor or open in new browser tabs)
- Longer term: do we need a formal mechanism to disposition warnings? Ignore error button where all errors need to be ignored explicitly before export/publish? Currently, no blocking exists. On MSL (MSlice), very conscious about red lines, but ignore yellows. Red need to be resolved by fixing underlying code problem (or talk about with team).
- Should we first start by just checking sequences in the workspace?
Checked for duplicates
Yes - I've already checked
Alternatives considered
Yes - and alternatives don't suffice
Related problems
Many missions have some form of onboard sub-routines such as VML blocks, APL semi-permanent macros, Sequence Libraries (MSL), and FCPL reusable sequences and need to be able to perform linting against these subroutines.
Describe the feature request
Develop a generic way to import different types of onboard sub-routine libraries. I believe this effort will have two parts: 1) providing a means for projects to upload library parsers (VML block library or FCPL RS SATF library parser) and 2) a generic sub-routine data structure into which different libraries can be imported and referenced for checking/linting.