Version Scheduling Goals and Conditions

Mythicaeda commented 9 months ago

Tickets addressed: Closes #1277
Review: By commit
Merge strategy: Merge (no squash)

Description

Sister PR to #1278.

Overview of changes:

The Scheduling Conditions table has been split into a metadata and definitions table. BREAKING CHANGE
Likewise, the Scheduling Goals table has been split into a metadata and definitions table. BREAKING CHANGE
Definitions are only editable by admin users.
Public and private toggles have been added. See #1278 for a breakdown of what this toggle does
A model spec for conditions and goals has been added. Because this spec does not require tracking additional metadata, there are only two associations. A model specification is a recommended set of goals/conditions and their versions for all plans using the model. Unlike in constraints, plan scheduling specs are not prepopulated due to being unable to know what a plan's model is. This can be resolved after #1311 is completed.
Scheduling Requests now record additional scheduling spec data in order to mirror Simulation Requests. Additionally, analysis_id has been officially made the pkey. This column has been a unique identifier for a while but was not officially changed until now.
The unusable "InMemoryStore" configuration has been removed. This code is completely unsupported, and the Scheduler uses a separate Mock implementation for tests.
The Scheduling Services have been simplified. Specifically, SpecificationService and SchedulerService have been flattened to their single real implementation, which defers to the implementation of their repositories. Additionally, some tweaks have been made to the PostgresRepository implementation to remove some unneeded calls to the DB.

Verification

DB Tests and Scheduling E2E Tests were updated to reflect the schema changes and for simplification. SchedulingTests for versioning and enabling/disabling goals were added

Documentation

Docs ticket to be created

Future work

After #1311 is completed, add a prepopulate trigger for plan specs.

Mythicaeda commented 9 months ago

Change pushed adds priority to the model goal spec, as per discussion with @dandelany

Mythicaeda commented 8 months ago

Change pushed was metadata, specifically:

There was an analyses relationship from Goals to the Goal Analysis table that was skipped when writing the new metadata for the split goal tables. This relationship has been restored.

dandelany commented 8 months ago

👍 finished testing the UI with @duranb - merging this and aerie-ui/1149 together.

NASA-AMMOS / aerie