search

NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

add some perf logging in SimulationDriver #1334

Closed parkerabercrombie closed 7 months ago

parkerabercrombie commented 9 months ago

Cherry pick performance logging change by @martyvona, from https://github.com/NASA-AMMOS/aerie/pull/1269. This seems useful as we continue to work on optimizing simulation performance.

JoelCourtney commented 9 months ago

Seems to work as expected 👍

martyvona commented 8 months ago

Thanks @parkerabercrombie and @JoelCourtney, I'd be happy to resolve the PR review comments above, however, I think perhaps we should just close this PR without merging for the following reasons:

  1. it looks like @DavidLegg has a different branch now with a more sophisticated implementation of resource profiling
  2. it's just a small PR, not MVP, and we all have a lot going on right now
mattdailis commented 7 months ago

Closing this PR based on @martyvona 's comment above. I'll frame the rationale a couple additional ways:

  1. The Clipper mission's requirements for performance are (in theory) more easily met with recent simplifications to their approach to using Aerie
  2. There are many efforts in flight that affect the simulation driver (#1096 , #1323 , #669), so the kinds of things that would be useful to log are in flux