search

NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

Fix Id Sequences on Constraint, Goals, and Conditions #1401

Closed Mythicaeda closed 7 months ago

Mythicaeda commented 7 months ago

Description

During the migrations that split constraints, goals, and conditions into metadata and definitions, we preserved the IDs. This meant, however, that the ID sequence used to generate new IDs were not advanced, causing issues with inserting new rows in these tables initially.

This PR creates a migration that advances the ID sequence on these tables to where it should be (the current max id + 1, or 1 if the table is empty). The down migrations are empty aside from marking the rollback as there is nothing to revert.

Verification

I first tested the migration against an empty database.

I then: 1) Spun up a 2.4.0 Aerie instance (the last one before versioning constraints) 2) Added 5 Constraints, Goals, and Conditions 3) Migrated to this branch 4) Created a new Constraint, Goal, and Condition

Documentation

No docs need to be updated.

Mythicaeda commented 7 months ago

Yeah. I went and checked the rest of the repo and the only other time we ever used the phrase "generated by default" (including within migrations) is on activity_directive and merge_staging_area. I'm not thrilled about the usage in merge_staging_area and imagine that that was just a result of copying the activity_directive table definition and tweaking it, but felt fixing it was out of scope for this PR.