Adds a missing merlin prefix in the force-resim workflow.
Additionally, updates the default provided service usernames in the deployment/.env to not have them match names of services.
This slipped by our tests initially because we had the usernames for services set to the name of the service schemas. When a user connects to the DB, their default search path is $username, public. Since this bug was in the merlin-server, the service had a default search path of merlin, public, which allowed it to successfully find and update the merlin.simulation table.
Verification
Manual verification, as the E2E tests were okay with this missing prefix.
CI Tests will now be effective thanks to @dandelany's tweaking of the e2eTest environment.
The DB Test Helper now grabs the Aerie and Postgres credentials from the user's environment/.env instead of assuming them. Note that currently the helper will prefer to use the .env in the e2eTest directory over the one at the root of the repo.
Description
Adds a missing
merlinprefix in the force-resim workflow.Additionally, updates the default provided service usernames in the
deployment/.envto not have them match names of services.This slipped by our tests initially because we had the usernames for services set to the name of the service schemas. When a user connects to the DB, their default search path is
$username, public. Since this bug was in the merlin-server, the service had a default search path ofmerlin, public, which allowed it to successfully find and update themerlin.simulationtable.Verification
Manual verification, as the E2E tests were okay with this missing prefix.
CI Tests will now be effective thanks to @dandelany's tweaking of the
e2eTestenvironment.The DB Test Helper now grabs the Aerie and Postgres credentials from the user's environment/
.envinstead of assuming them. Note that currently the helper will prefer to use the.envin thee2eTestdirectory over the one at the root of the repo.Documentation
Future work