NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

Cannot Unselect Global Scheduling Conditions in "Manage Scheduling Conditions" Popup #1417

Open meganmjones opened 7 months ago

meganmjones commented 7 months ago

Checked for duplicates

No - I haven't checked

Is this a regression?

No - This is a new bug

Version

2.6.2

Describe the bug

When trying to setup global scheduling conditions in a plan, I used the "Manage Scheduling Conditions" Panel to select some that were previously created on an older plan (& built on a different mission model). Screenshot 2024-04-23 at 5 29 18 PM

I selected the desired scheduling conditions to apply and then clicked "update" and saw them applied as expected in the scheduling conditions panel. Screenshot 2024-04-23 at 5 39 22 PM

However, I've noticed that when I go back into the popup to dis-select a condition from being applied to the plan, when I uncheck them and hit "Update" the conditions still appear in the Scheduling Conditions panel after I see the "Scheduling Conditions Updated Successfully" message. And when I go back to the "Manage Conditions" popup I see the same conditions I tried to dis-select still selected. Ideally, these conditions wouldn't be associated with the plan anymore when they're not selected in the "Manage Scheduling Conditions" popup.

Note this is separate from enabling and disabling conditions to being applied upon scheduling runs off a selected plan. I can see cases where I may have accidentally added too many conditions or a duplicate in the manage conditions panel and want to remove them from being applied to the plan at all. This is the case that is not functioning as expected. Screenshot 2024-04-23 at 5 49 04 PM

Reproduction

  1. Create one plan on a given mission model and develop several global scheduling conditions
  2. Make a new plan built off a new mission model and navigate to the "Scheduling Conditions" panel
  3. Go to the "Manage Conditions" popup and select the conditions you just created
  4. Check to make sure they were successfully applied to your plan
  5. Navigate to the "Manage Conditions" popup again and try to unselect the conditions you just added
  6. Note if those conditions are still applied to the plan after attempting to unselect them

Logs

No response

System Info

Chrome, Mac

Severity

Minor