This PR fixes or silences all warnings in the current build process. For silenced warnings that need justification, I've put my reasons in the commit descriptions.
The only one that I'm not sure about is the first commit. @goetzrrGit I specifically need your review for that one line. Basically, the TS compiler in sequencing-server gave a warning that said something like "import assertions aren't allowed unless module is set to esnext or nodenext". So I set "module": "esnext" in tsconfig. I have no idea what this change means or if it will cause problems.
Verification
If tests pass and successful builds are silent, I'm happy. You should be able run ./gradlew build --warning-mode all and see no output other than the Build Successful message.
Description
This PR fixes or silences all warnings in the current build process. For silenced warnings that need justification, I've put my reasons in the commit descriptions.
The only one that I'm not sure about is the first commit. @goetzrrGit I specifically need your review for that one line. Basically, the TS compiler in sequencing-server gave a warning that said something like "import assertions aren't allowed unless module is set to esnext or nodenext". So I set
"module": "esnext"in tsconfig. I have no idea what this change means or if it will cause problems.Verification
If tests pass and successful builds are silent, I'm happy. You should be able run
./gradlew build --warning-mode alland see no output other than the Build Successful message.Documentation
Future work
The war for quiet builds is eternal.