NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

Upgrade docs give incorrect env var name for db host in aerie-scheduler #1462

Closed parkerabercrombie closed 4 months ago

parkerabercrombie commented 5 months ago

Checked for duplicates

No - I haven't checked

Is this a regression?

Yes - This worked in a previous version

Version

2.8.0

Describe the bug

Upgrade guide for 2.7.0->2.8.0 lists the db host var for the scheduler and scheduler worker containers as AERIE_DB_HOST

renamed envvars: SCHEDULER_DB_SERVER -> AERIE_DB_HOST

However, the code is using env var AERIE_DB_SERVER: https://github.com/NASA-AMMOS/aerie/blob/develop/scheduler-server/src/main/java/gov/nasa/jpl/aerie/scheduler/server/SchedulerAppDriver.java#L145 https://github.com/NASA-AMMOS/aerie/blob/develop/scheduler-worker/src/main/java/gov/nasa/jpl/aerie/scheduler/worker/SchedulerWorkerAppDriver.java#L127

Either code should change to use what the docs say, or docs should change to match code.

Reproduction

N/A

Logs

No response

System Info

N/A

Severity

Moderate