Bug fix for coexistence goal valueAt usage

NASA-AMMOS / aerie

A software framework for modeling spacecraft.

https://nasa-ammos.github.io/aerie-docs/

MIT License

73 stars 19 forks source link

Bug fix for coexistence goal valueAt usage #1485

Closed adrienmaillard closed 4 months ago

adrienmaillard commented 5 months ago

Tickets addressed: Closes #1378
Review: By commit
Merge strategy: Merge (no squash)

Description

The interval for instantiating parameters of an activity has been relaxed to Interval.FOREVER instead of restricting it to the start time of the activity.

Verification

A new test reproducing the failure has been added and is now passing.

Documentation

None.

Future work

I found #1484 while working on this one.

adrienmaillard commented 4 months ago

@JoelCourtney and I discussed this and we found another way of fixing the issue.

adrienmaillard commented 4 months ago

I haven't added a nested parameter test. It's not straightforward at all and I'd prefer investigate this in another ticket.