NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

Fix DiscreteEffects.remove #1499

Closed DavidLegg closed 4 months ago

DavidLegg commented 4 months ago

Description

DiscreteEffects.remove is one of two methods meant to implement a FIFO queue resource (the other is DiscreteEffects.add). However, it was written to remove the last element of the queue, when it should have removed the first element.

Verification

Tested in the CADRE model while working with @bashbash

Documentation

Documentation for this function was correct, now the code matches that documentation.

Future work

N/A