NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

Confusing CE behavior in case of creating a rule for an activity that doesn't exist #1528

Open cartermak opened 3 months ago

cartermak commented 3 months ago

Checked for duplicates

No - I haven't checked

Is this a regression?

No - This is a new bug

Version

2.11.2

Describe the bug

Small note for error handling behavior. No need for immediate resolution.

When uploading expansion rules and sets via the API, Aerie will allow the user to create an expansion rule in a model where an activity type doesn't exist. The new rule appears in the Aerie UI under the "Rules" page (with the specified parcel and mission model IDs), and the UI doesn't present any errors unless you go into "Edit" mode for the rule, at which point the editor gives an error for the missing ActivityType definition.

When trying to create a set via the API, we get a "No activity with name: in mission model with id:" error. When trying to create via the Aerie UI, it's confusing because the rule appears under "Rules" but it isn't available to select when creating the set.

Reproduction

Logs

No response

System Info

Aerie 2.11.2 on Clipper cloud deployment. API interactions via Aerie-CLI.

Severity

Minor