NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

Use MissionModelId Class instead of String #1533

Closed Mythicaeda closed 3 months ago

Mythicaeda commented 3 months ago

Description

Related Frontend PR.

Updates the Merlin part of the codebase to use a numerical MissionModelId record instead of a raw String to represent model ids. This makes it consistent with the rest of the codebase and the database.

Breaking change as this replaces the ID! in actions.graphql with Int!. This change may impact users of the following actions:

Users will be impacted only if they were using a query variable for the missionModelId argument of these actions. If they were, this can be fixed by changing the type of that query variable from ID! to Int!

Two deprecated actions have also been impacted. getActivityEffectiveArguments and resourceTypes. Use getActivityEffectiveArgumentsBulk in place of getActivityEffectiveArguments. Query the resource_type table in place of the resourceTypes action.

Verification

Unit tests were updated to reflect the change in type.

Documentation

Docs PR

Future work

dandelany commented 3 months ago

👍 looked at this with @Mythicaeda on a call also, thanks!