search

NASA-AMMOS / aerie

A software framework for modeling spacecraft.
https://nasa-ammos.github.io/aerie-docs/
MIT License
73 stars 19 forks source link

GH workflow to publish images for PRs labeled 'publish' #1540

Closed dandelany closed 3 months ago

dandelany commented 3 months ago

Supporting this issue: https://github.com/NASA-AMMOS/aerie/issues/1538

This change will cause the GH "Publish" workflow to run whenever an aerie PR is given the "publish" label, which will cause Docker images to be published from the PR branch, tagged with the PR number eg. pr-1540

The published aerie PR can then be referenced in an aerie-ui PR with a flag in the PR body that looks like eg. ___REQUIRES_AERIE_PR___="1540", which will cause the aerie-ui e2e tests to use the published pr-1540 aerie images during testing rather than the default develop branch.

Mythicaeda commented 3 months ago

In order to test the synchronization event, could you flatten the working commits and force push?

Mythicaeda commented 3 months ago

The PR isn't actually blocked on the failure, it's blocked on a lack of an approval. The reason it isn't blocked is because the Publish workflow isn't a required workflow, unlike our test workflow.

dandelany commented 3 months ago

In order to test the synchronization event, could you flatten the working commits and force push?

Done! will do the same for the other 2 PRs.