NASA-AMMOS / slim

Software Lifecycle Improvement & Modernization
https://nasa-ammos.github.io/slim/
Apache License 2.0
24 stars 9 forks source link

Issue #46: SLIM Python Starter Kit for review. ... #72

Closed jpl-jengelke closed 1 year ago

jpl-jengelke commented 1 year ago

Purpose

riverma commented 1 year ago

Great progress here @jpl-jengelke - looking good. My general comment is that it’d be helpful to have a section that’s clearly marked “QuickStart” or something to that equivalent. In other words, if I didn’t have the time to read the full background and wanted to hit the ground running - which section should I jump to?

jpl-jengelke commented 1 year ago

This PR was reworked to sync it with the main branch. Additional changes to be committed shortly.

jpl-jengelke commented 1 year ago

Please review. Here's the CI Starter Kit in context: https://github.com/NASA-AMMOS/slim/blob/issue_46/continuous-integration/starter-kits/README.md

jpl-jengelke commented 1 year ago

47 ERROR HTTPError: 403 Forbidden from https://test.pypi.org/legacy/
48 Invalid or non-existent authentication information. See
49 https://test.pypi.org/help/#invalid-auth for more information.



Any idea?

It looks like an authentication issue. Are you sure the PYPI_API_TOKEN is set right between Test PyPi and GitHub?

Update: It was an authentication issue. And, that's because the instructions were a little unclear. So I'm updating these to clarify our approach. Changes are complete @riverma , please re-review.

riverma commented 1 year ago

Thanks for the recent commits @jpl-jengelke!

I'm still getting some errors. I think I'm pretty close, but some clarifications:

  1. Are the local egg building steps required prior to testing the build / deploy from GitHub Actions?
  2. For the local build, I'm getting an error following these directions - maybe we can debug this together:
    
    $ python3 -m build --wheel && python3 setup.py sdist --format=zip 
    * Creating venv isolated environment...
    * Installing packages in isolated environment... (importlib-metadata>=3.6;python_version<='3.7', setuptools>=62.6, setuptools_scm[toml]>=6.4.2, wheel>=0.37.1)
    * Getting build dependencies for wheel...
    running egg_info
    writing my-test-proj-1380283520852.egg-info/PKG-INFO
    writing dependency_links to my-test-proj-1380283520852.egg-info/dependency_links.txt
    error: Problems to parse EntryPoint(name='my-test-proj-1380283520852', value='my-test-proj-1380283520852.hello_world:main', group='console_scripts').
    Please ensure entry-point follows the spec: https://packaging.python.org/en/latest/specifications/entry-points/

ERROR Backend subprocess exited when trying to invoke get_requires_for_build_wheel

jpl-jengelke commented 1 year ago

Changes to clarify steps: