search

NASA-IMPACT / EIC-Mobile

EIC Mobile Concept
https://earth.gov/mobile-climate-mapper/
1 stars 0 forks source link

EIC 3D Globe v2 #2

Closed dzole0311 closed 1 month ago

dzole0311 commented 2 months ago

The PR introduces a few changes for the EIC interactive app:

  1. Introduce interactive geodesic buffer on the 3D globe as a way to pick points of interest
  2. Simplify the layout of the app, as per the designs from @faustoperez
  3. Chart adjustments, code clean up
netlify[bot] commented 2 months ago

Deploy Preview for eic-mobile-demo ready!

Name Link
Latest commit 6395d347d7de3dd5afe5c532a4e7bcdaf928bb6b
Latest deploy log https://app.netlify.com/sites/eic-mobile-demo/deploys/66d6cfb2c9541e0008387035
Deploy Preview https://deploy-preview-2--eic-mobile-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

slesaad commented 2 months ago

I'm not sure how complete this PR is supposed to be, but I noticed some inconsistencies:

  1. the initial view doesn't show any vitals/chart - would it make sense to show that it's loading and populate the values for the area that is selected when it's available?
  2. when I have the vitals/chart on the screen for one dataset, then I click on a different dataset, it shows the same values until I drag the buffer to a different area (maybe solving 1 would solve this?)
  3. might need to confirm that the stats are generated correctly (ex - in the attached image, the max value is shown as 0.13 but there are clearly values greater than 0.20 in the chart image
dzole0311 commented 2 months ago

Thanks for taking a look, @slesaad! You're right — it isn't a complete PR. I mainly opened it to have a deployment URL readily available. We're still refining the curated experience with @faustoperez, so some elements (and datasets) will change, and that's why I haven’t fully addressed the rest of the issues yet.