search

NASA-IMPACT / EIC-Mobile

EIC Mobile Concept
https://earth.gov/mobile-climate-mapper/
1 stars 0 forks source link

Adding Digital Analytics Program (DAP) header to the app #68

Closed amarouane-ABDELHAK closed 1 month ago

amarouane-ABDELHAK commented 1 month ago

Adding Digital Analytics Program (DAP) header to the app but only if deployed to .gov domains (staging and production GitHub environments)

netlify[bot] commented 1 month ago

Deploy Preview for eic-mobile-demo ready!

Name Link
Latest commit 99ddb8c35a9e2ed5abc14383164ddde66575d5d0
Latest deploy log https://app.netlify.com/sites/eic-mobile-demo/deploys/6710d949589a090008b49f3c
Deploy Preview https://deploy-preview-68--eic-mobile-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dzole0311 commented 1 month ago

Thanks @amarouane-ABDELHAK, looks good! I made a small adjustment to the Vite config and I've also added the ADD_DAP_SCRIPT variable to the Netlify deployment settings, so the DAP script should now appear in the deploy previews as well. We can also set it to false for the Netlify previews if we see its adding noise to the DAP analytics.

amarouane-ABDELHAK commented 1 month ago

I had the impression that we only need DAP script on a public facing government websites (.gov domains) we will not need to put them for the netlify previews) https://github.com/NASA-IMPACT/EIC-Mobile/issues/38#issuecomment-2417667026

dzole0311 commented 1 month ago

I had the impression that we only need DAP script on a public facing government websites (.gov domains) we will not need to put them for the netlify previews)

Okay, I removed the variable from the Netlify settings (I missed the original comment in the other issue).