NASA-IMPACT / admg-backend

Apache License 2.0
2 stars 0 forks source link

Wrong tag present when transitioning from “Create/In Progress” to “Awaiting Staff Review” and “Awaiting Admin Review” #549

Closed heidimok closed 11 months ago

heidimok commented 1 year ago

Issue Overview

How To Reproduce:

  1. Go to https://admgdev.nasa-impact.net/v2/instrument/c8e3cad2-71f1-4d6e-826f-f37eb3749691/edit/c8e3cad2-71f1-4d6e-826f-f37eb3749691
  2. Ensure you’re on the “Edits” tab
  3. The yellow label states that the draft is “In Admin Review” although it’s been transitioned to “Awaiting Review” and has not made it to the Admin Review stage yet (see screenshot below)

Screenshots

image

Zoomed in

image

Expected Behaviour

The status text includes statuses for Awaiting Review and Awaiting Admin Review

OR

If we don't think it's an easy change to add more statuses, we can opt to only show the next status once it's past the 'awaiting status. For example, stay on the In Progress status until it's actually claim an In Review.

heidimok commented 11 months ago

Sharing some color codes for the tabs @edkeeble

Because the awaiting review and awaiting admin review are almost like pre-steps to the actual status, I opted to share the same colors to prevent having too many different status colors.

Created F37500 In Progress CF3F02 Awaiting Review 2E86AB In Review 2E86AB Awaiting Admin Review 42BCD7 In Admin Review 42BCD7 Published 4DA167

heidimok commented 11 months ago

Work has been merged to the canonical workflow branch, but not deployed to dev automatically. Will need to be deployed along with other bugs once everything is merged into the branch.