Error message when deleting a campaign, instrument, or platform

[heidimok]

Issue Overview

• This issue applies to the main Campaign, Platform, and Instruments that are published
• You get an error when deleting

How To Reproduce:

1. Go to a published campaign (Heidi's delete test: https://admgdev.nasa-impact.net/v2/campaign/8ec24a8e-cb63-47c5-a4b9-72e0f888bf7e/published/8ec24a8e-cb63-47c5-a4b9-72e0f888bf7e)
2. Click the delete button
3. Click create a delete draft
4. Error

Screenshots (flow)

Expected Behavior

Expect to be able to create a delete draft

The status then becomes "In Trash"

[heidimok]

After learning a little more about the Deletion flow, I'm adding more thoughts on the user experience.

Deletions can be confusing in the MI. Key notes:

• To delete a campaign, users need to create a “delete draft”
• Delete drafts need to go through the entire approval process just like any other draft.
• Once a delete draft as been published, the actual Campaign record (what is published on the UI) will be permanently deleted.
• However, all the delete drafts associated with the backend change model will remain.

Step 1: User deletes a published item (E.g. Campaign)

• A delete drafted can only be created on a published campaign view
• Upon clicking "Delete", a confirmation modal appears (existing behavior)

Step 2: User goes through deletion approval process (multi-step process)

• Just like any draft in the backend change model, a delete draft needs to go through the full approval process
  • Note: It is unclear if this was an actual requirement from the start or if this is because all drafts in the change model need to go through this process. From a user's perspective, it could be enough to simply complete step 1 but we will follow how the system works.
• Users are navigated to the edit tab just like they would if they were making an update. This time, we see a warning alert that lets users know they are in a deletion process.
  • Note: In the current workflow, users are navigated to the main campaign table. However this requires extra steps to go back into the delete draft so we might as well speed up that process.

Step 3: Upon publishing a delete draft, a final confirmation modal appears

• Users need to go through ALL the approval steps
• This modal is to remind users again that deleting will remove contents from the UI (the actual record will be permanently deleted), but not the MI. They can see view historic drafts.

Step 4: Users are brought back to the campaign table

• The campaign will still appear in the MI, but now with an In Trash status
• The campaign should NO LONGER be on the UI as the published record has been permanently deleted

---

What if a user goes back to the main Campaign table during a deletion approval processs?

• Meanwhile, on the main Campaign table UI, the campaign is still there, but tagged with a Delete action.
• The status is create because a create draft as been made for a delete action.
• The new MI workflow table doesn't include an explicit column for the draft Action (create, update, delete). This was intention in the design to avoid confusion of showing too many status columns. The user will either need to filter by action or click into the Campaign in order to see that it's a delete action. I think this tradeoff is okay because deletions are not common and it's better to optimize for the experience of creating and updating.

What if a user clicks into a deleted campaign that was published?

• They can still view the published tab, but there will be an alert that lets them know the published draft was deleted
• They can navigate to the History tab if they want to reference past versions

What if a user makes a mistake and wants to undo a delete draft?

• If a user clicks "Undo Delete" during the deletion approval process, they will see a model that explains what will happen
  • They will be taken back to the most recent update draft on the edit tab and save the content
  • They will NOT be able to view the most recently published draft

What if a user goes to view a deleted campaign's history?

• They can see all previous drafts including delete drafts (but not the published delete draft)
• They can view these version, but they cannot revert and edit. They can only see the content as reference if they want to recreate the campaign

What if a user deletes a campaign and wants to recreate it?

• They can reference the deleted draft content, but they won't be able to use the same short name (since it still exists in the system).

[heidimok]

Update Oct 23, 2023:

After clarifying with Stephanie some expectations around the deletion workflow in the MI, and asking if it was intended from a curator's viewpoint to have to have SO many steps, we decided that it's not necessary for deletion drafts to have to go through the entire approval process.

Current:

1. Click create delete draft on a published version
2. Confirm delete draft, get taken back to the campaign table
3. Find and click into the newly created delete draft on the campaign table again
4. Go through the entire approval process for a delete draft
5. Publish that delete draft
6. Now the published version is finally delete (but the history drafts remain)

New:

1. Click 'delete' on a published version
2. Confirm the delete
3. You are navigated back to main list page where the draft is now In Trash status
4. Successful deletion alert (if possible)

[heidimok]

Nov 24, 2023

• Tested this in https://admgdev.nasa-impact.net/v2/campaign
• Looking quite good all the way until users are returned to the Campaign page

https://github.com/NASA-IMPACT/admg-backend/assets/10764915/44d50d72-b54e-48d0-a43d-80b3dabb7fcd

• Want to check in with @Tammo-Feldmann Monday next sprint before closing this issue because there is something unexpected showing up after a campaign is deleted. I would expect the campaign to have an In Trash label instead of showing up as ---

[heidimok]

Closing this as it works when tested by Tammo but once we merge to staging I will do a final check to make sure.