search

NASA-IMPACT / admg-backend

Apache License 2.0
2 stars 0 forks source link

Fix links to published-details #585

Closed alukach closed 10 months ago

alukach commented 10 months ago

The published-details URL requires a canonical_uuid (not pk):

https://github.com/NASA-IMPACT/admg-backend/blob/292c4ea7108da55d35c0d8a39ad34160f974dee2/app/admin_ui/urls.py#L43-L47

alukach commented 10 months ago

@Tammo-Feldmann thanks. The classic smell for me is when I open a PR and start looking at the files changed to write up a description of the PR and find myself getting overwhelmed with all the different purposes of changes. My workflow is typically:

  1. Create a backup/{feature-name} branch just in case things go downhill.
  2. Reset all the commits back to the origin target branch: git reset --soft origin/{destination-branch}
  3. Start staging individual files (or just portions of files) for commit, then checkout a new branch for just that theme of change, push those changes to just that branch, then go back to the feature branch and start again: git add {...files} && git checkout -b feature/{change-theme} && git push && git checkout -