search

NASA-IMPACT / admg-casei

ADMG Inventory
https://impact.earthdata.nasa.gov/casei/
Apache License 2.0
1 stars 0 forks source link

Issue 561/glossary work #571

Closed naomatheus closed 10 months ago

naomatheus commented 11 months ago

Addresses #561

Summary:

allow links in glossary sections add props validation for LinkSection includes updates pre-commit config merge in from an awaiting PR casei-precommit

naomatheus commented 11 months ago

No conflicts with the base branch but if there are any issues with testing I can revisit

naomatheus commented 11 months ago

This was a bit more complicated than I thought, but looking forward to what reviewers think. There might be a way to simplify? I thought I could use the StringTemplateParser module but it wasn't flexible to be applied to the Glossary page. However, it could be better to be able to use that one module for both the FAQ and Glossary pages

edkeeble commented 11 months ago

Can we split the pre-commit work out from this PR? I have some thoughts on that approach which shouldn't block updates to the glossary.

naomatheus commented 11 months ago

Yep no problem @edkeeble

naomatheus commented 10 months ago

Hey @edkeeble This looked stuck in "checking branch status" status. But I am re-running the jobs now and it appears all clear.

naomatheus commented 10 months ago

Corrected a potential typo. Will verify

naomatheus commented 10 months ago

PR corrected @edkeeble