NASA-IMPACT / admg-casei

ADMG Inventory
https://impact.earthdata.nasa.gov/casei/
Apache License 2.0
1 stars 0 forks source link

Confirm coming soon page contents #663

Open LanesGood opened 1 month ago

LanesGood commented 1 month ago

The coming soon page should render content from the /unpublished_drafts API endpoint. Currently it appears that not every item at the endpoint is included on the page. Investigate and confirm page contents, and modify filters or requirements as needed.

smwingo commented 2 weeks ago

discuss more at Thur 22 Aug dev seed meeting

LanesGood commented 2 weeks ago

@willemarcel has confirmed that the coming soon page renders content from the /unpublished_drafts endpoint that meets the following criteria:

cc @smwingo @als0076 @EJwalker13

LanesGood commented 1 week ago

From @als0076 on slack:

platforms or instruments that are in the curation process are already in CASEI, so they will just be update drafts so will never be on the coming soon page.

@smwingo suggests changing to:

update drafts in review? and/or admin review?

This sounds like a proposed backend change to update the /unpublished_drafts endpoint to include All content that is in review and/or admin review, and not just new entries. Is this correct? If so we can explore what would be included with this change.

LanesGood commented 1 week ago

@smwingo @als0076 @EJwalker13 are there any needed changes to the /unpublished_drafts endpoint creation? I would suggest that the team take a look at each status filter in the Management Interface for campaigns, platforms, and instruments, in order to see what is desired to show on the "Coming Soon" page.

als0076 commented 1 week ago

I would say for the unpublished drafts the coming soon page would need to show drafts that at least have a status of "Awaiting Review" and later. I think showing just drafts with a label of "In Progress" would not accurately display the drafts actively being worked on. @smwingo can correct me if I am wrong with this?

Update drafts should probably follow a similar process.

smwingo commented 1 week ago

yes ^^^ I agree w/ Ashlyn -- thought i think update drafts that are just "created" would actually be items that already have been (partly) curated and might already, technically, "be" in CASEI -- eg: instruments that have very limited metadata and then later undergo full curation -- but this is fine, bc we'd want to show that the full updates are "coming soon"

so yes - as ashlyn described.

smwingo commented 1 week ago

Question: will any drafts for things that have been "deleted" then show up? bc we don't want those...

smwingo commented 4 days ago

need clarity to define this further.

what items associated with each curation status

smwingo commented 4 days ago

Ashlyn + Lane to discuss.

LanesGood commented 3 days ago

Discussed with @als0076 and we've concluded that the following should be the status filters to compose the unpublished_drafts API response: [Awaiting Review, In Review, Awaiting Admin Review, In Admin Review]

We agreed that the "New entry" filter still made sense as the "update drafts" content will reflect items already discoverable on the CASEI platform; it would thus not make sense to include the names of those items on the "Coming Soon" page.