Closed leothomas closed 3 years ago
Thanks @leothomas
detections-ships.json
seems to check out. My only comment is that the interface shows detections in orange (not red), I can update the description for all ML detectionsRunning this with 1.8.0 of the dashboard, I noticed a couple of issues. Unsure whether they should be solved on the API, or frontend, but raising them here:
"domain": [ "2020-01-09T00:00:00Z", "2020-07-08T00:00:00Z" ]
. Instead of treating these as two discrete dates, the frontend interprets this as a range daily dates with the domain being the start and end dateTested this locally and the data seems to show up correctly. I encountered some errors, but I think it's because I don't have a planet key.
I did notice the domain error reported by @olafveerman, and this is a problem with the frontend. We were considering domains with 2 dates to be a range according to the time unit. This has been the case and worked until this moment. The very useful isPeriodic
property of the api response was not being used.
Long story short, here's the PR with the fix: https://github.com/NASA-IMPACT/covid-dashboard/pull/455
Fixed the issue with detections-vehicles
missing background scenes (issue was due to the fact that detections-vehicles
relies on Skysat imagery, which is not available through the Planet tile endpoint (detections-plane
and detections-ship
rely on Planet imagery which is available through the Planet tile endpoint).
@olafveerman re: observations colour - I'm not seeing anywhere on the backend to specify the colours of the observations. If that's not fixable through the front end, I'm happy to update the info
field of each of the detections-*
metadata files to specify that the observations are show in orange (instead of red)
This looks good! Holding off on merging for a couple of days, until the Story feature has been launched and stable.
@olafveerman This PR has been open for a while. Can we merge, now that the Story feature has been launched?
What I did:
Added
detections-vehicles
dataset - addresses covid-dashboard issue #440How I did it:
Extracted scene_ids for each feature in the two geojsons currently in S3 and built + uploaded a
detections_scenes.csv
file.Created a new dataset metadata file called
detections-vehicles.json
which is very similar todetection-plane.json
anddetections-ship.json
.Added
detections-vehicle
to all datasets which hasdetections-ship
anddetection-plane
as exclusive datasetsHow you can test it:
Run
docker-compose up --build
http://localhost:8000/v1/datasets
notice a new dataset fordetections-vehicles
is present (with{spotlightId}
in url, since no spotlight has been specified)http://localhost:8000/v1/datasets/la
notice that thedetections-vehicles
is still presenthttp://localhost:8000/v1/datasets/ny
notices that thedetections-vehicles
is no longer present@olafveerman @drewbo would love some feedback on the
detections-vehicles.json
metadata files (I copy-pasted the description fromdetections-ships.json
, not sure if theinfo
field is missing anything)@danielfdsilva tagging you because the format of the geojsons in s3 seems different from the other
detection-*
datasets. Let me know if you need anything in order to implement in the front end@lillythomas fyi