NASA-IMPACT / csdap-cumulus

SmallSat Cumulus Deployment
Other
1 stars 0 forks source link

Updated the Ruby dependencies to address the SNYK Tickets #501, #502, #503 #346

Closed krisstanton closed 4 months ago

krisstanton commented 4 months ago

Ruby Updates to address SNYK issues. https://github.com/NASA-IMPACT/csda-project/issues/501 https://github.com/NASA-IMPACT/csda-project/issues/502 https://github.com/NASA-IMPACT/csda-project/issues/503

Deployment and Smoketest passed on Sandbox.

krisstanton commented 4 months ago

I think github skipped deploying to UAT because this PR makes zero chances to the terraform plan. Merging now.

chuckwondo commented 4 months ago

It skipped deploying because you didn't change any files that warrant redeployment. This is based upon the files listed under paths in this file: https://github.com/NASA-IMPACT/csdap-cumulus/blob/main/.github/workflows/main.yml. Since Gemfile.lock in not in that list, no deployment was triggered. That's expected behavior.

krisstanton commented 4 months ago

It skipped deploying because you didn't change any files that warrant redeployment. This is based upon the files listed under paths in this file: https://github.com/NASA-IMPACT/csdap-cumulus/blob/main/.github/workflows/main.yml. Since Gemfile.lock in not in that list, no deployment was triggered. That's expected behavior.

Thanks Chuck, I had not realized that was the reason. That's good to know!