NASA-IMPACT / csdap-cumulus

SmallSat Cumulus Deployment
Other
1 stars 1 forks source link

Snyk Medium vulnerability: inflight - Missing Release of Resource after Effective Lifetime #404

Closed hbparache closed 3 days ago

hbparache commented 1 month ago

Introduced through @cumulus/common@18.2.0 and @cumulus/cmrjs@18.2.0 Exploit maturity Proof of Concept Show less detail Detailed paths Introduced through: csdap-cumulus@1.0.0 › @cumulus/common@18.2.0 › @aws-sdk/signature-v4-crt@3.575.0 › aws-crt@1.21.0 › mqtt@4.3.8 › help-me@3.0.0 › glob@7.2.3 › inflight@1.0.6 Fix: No remediation path available. Introduced through: csdap-cumulus@1.0.0 › @cumulus/cmrjs@18.2.0 › @cumulus/cmr-client@18.2.0 › @cumulus/common@18.2.0 › @aws-sdk/signature-v4-crt@3.575.0 › aws-crt@1.21.0 › mqtt@4.3.8 › help-me@3.0.0 › glob@7.2.3 › inflight@1.0.6 Fix: No remediation path available. Security information Factors contributing to the scoring: Snyk: CVSS v3.1 6.2 - Medium Severity NVD: NVD only publishes analysis of vulnerabilities which are assigned a CVE ID. This vulnerability currently does not have an assigned CVE ID. Why are the scores different? Learn how Snyk evaluates vulnerability scores Overview Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres function due to improperly deleting keys from the reqs object after execution of callbacks. This behavior causes the keys to remain in the reqs object, which leads to resource exhaustion.

Exploiting this vulnerability results in crashing the node process or in the application crash.

Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.

To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.

ShreyNiraula commented 3 days ago

This issue is related to memory leak issue caused by improper deletion of keys in request object by inflight module. There is no current fixed version available and best solution could be to avoid the use of this library.

Further, this should not be a much of problem since in order to trigger memory leak, attacker need to have the ability to influence asynchronous call that use inflight module. But, this is not exposed to the outside.

As it is from @cumulus, this needs to be fixed by Core team.