NASA-IMPACT / hls-vi

0 stars 0 forks source link

Create a STAC item for HLS_VI granules #21

Closed SwordSaintLancelot closed 1 month ago

SwordSaintLancelot commented 1 month ago

PR is created to create an STAC item for the HLS_VI granule.

Script description

generate_stac_items.py is the script that generates a STAC item for the HLS_VI granule. In order to create the item, the script requires the cmr xml file of the HLS_VI granule along with the file name that should contain the STAC item in JSON format. It also requires the DAAC information from where the data is being fetched.

Other arguments and information are provided within the script in the form of function descriptions and arguments.

chuckwondo commented 1 month ago

@SwordSaintLancelot, please fix these flake8 errors: https://github.com/NASA-IMPACT/hls-vi/actions/runs/9981613539/job/27585616075?pr=21

chuckwondo commented 1 month ago

@SwordSaintLancelot, you can run linting and test locally by running the following, as mentioned in the README.md:

make test

That should show you the same errors as the CI build, so you can address them locally before pushing your changes.

chuckwondo commented 1 month ago

You must also add missing dependencies to the install_requires list in setup.py. I see that you're missing pystac, geojson, and perhaps others.

SwordSaintLancelot commented 1 month ago

@chuckwondo The code has been updated and checked. All the tests are passed. You can review it and let me know if there are any changes needed.

madhuksridhar commented 1 month ago

@chuckwondo @SwordSaintLancelot , received href for VI from LP:

I believe the correct URL should look like this for VI: https://data.lpdaac.earthdatacloud.nasa.gov/lp-prod-public/HLSL30_VI.020/ HLS-VI.S30.T47UNU.2024046T042851.v2.0/ HLS-VI.S30.T47UNU.2024046T042851.v2.0_stac.json

SwordSaintLancelot commented 1 month ago

I will update this URL in the code and push the changes.

chuckwondo commented 1 month ago

I will update this URL in the code and push the changes.

You can update your branch with your open PR since we haven't merged it yet.