search

NASA-IMPACT / nasa-apt

Code and issues relevant to the NASA APT project
Apache License 2.0
6 stars 0 forks source link

APT generated citations not formatted correctly #825

Open bwbaker1 opened 11 months ago

bwbaker1 commented 11 months ago

Description

The current format of generated ATBD citations changed at some point and is no longer correct.

Current example from UI:

Image

It should look like the following: Hu, C., Werdell, J., O'Reilly, J., Feng, L., Lee, Z., Franz, B., Bailey, S., & Proctor, C. (Publication Date). Chlorophyll a, v1.0. NASA Algorithm Publication Tool. (DOI).

Format: lastname, first initial., lastname, first initial., ..... & lastname, first initial. (Publication Date). Title, Version. Publisher. Online Resource. DOI.

The citation link is also incorrect. It is missing "apt/"

Image

bwbaker1 commented 11 months ago

@ashleyriddle92 Will you review this format and verify it is correct?

ashleyriddle92 commented 11 months ago

If were to use a journal format, it would look like this:

Hu, C., Werdell, J., O'Reilly, J., Feng, L., Lee, Z., Franz, B., Bailey, S., & Proctor, C. (Publication Date). Chlorophyll a, v1.0. NASA Algorithm Publication Tool. (DOI).

kamicut commented 6 months ago

Hello @bwbaker1 if the document has an existing DOI (as input in the identifying information), should we use the existing DOI or the generated URL pointing to the document?

bwbaker1 commented 6 months ago

@kamicut We should use the existing DOI.

wrynearson commented 6 months ago

@bwbaker1 this is on staging and ready for your review

bwbaker1 commented 6 months ago

@wrynearson There are a few issues. This is what I get.

Screenshot 2024-03-27 at 10 28 33 AM

It should look like this: Baker, B. & Riddle A. (publication date). APT Citation Generator Test, v1. NASA Algorithm Publication Tool. (DOI)

So only the first name initial should be displayed and the publisher should be italicized.

kamicut commented 6 months ago
  1. @bwbaker1 could you check that you've entered the name of the editors in the format Lastname, Firstname in the Identifying information section? We are standardizing those inputs across the application so that we can correctly identify the last name(s)
  2. I will look into italicizing the publisher.
wrynearson commented 6 months ago

@bwbaker1 are these the screenshots you meant to include? The citation is being driven by the citations form in the 1st step of the edit flow (Identifying Information), not the contacts form in the 2nd step

bwbaker1 commented 6 months ago

@wrynearson Sorry. but I guess I didn't preview those for commenting. It should have been these.

Screenshot 2024-03-28 at 7 53 46 AM

Screenshot 2024-03-28 at 7 54 08 AM

The final citation should be the following:

Baker, B. & Riddle, A. (publication date - null). APT Citation Generator Test, v1. NASA Algorithm Publication Tool. (10.1029/2022EA002516).

wrynearson commented 6 months ago

We're working on the first names not appearing. We should have a fix this week.

For the italics, it looks like it will require more changes. How critical is this issue? Could users who are copying the citation apply formatting changes elsewhere for the time being?

(publication date - null)

If there is no publication date, should we explicitly say "publication date - null", or is "null" enough?

bwbaker1 commented 6 months ago

@wrynearson This isn't a high priority right now. It looks better than it did before. The bigger issue is #843 because we have someone ready to publish but can't until the order of the contacts is correct. Also, another document is in review, so that is going to lead to the same issue soon.