search

NASA-IMPACT / nasa-apt

Code and issues relevant to the NASA APT project
Apache License 2.0
6 stars 0 forks source link

Check into why some figure images do not always display on TEMPO ATBD #896

Open bwbaker1 opened 1 month ago

bwbaker1 commented 1 month ago

The TEMPO team is rather continuously encounter figure images not displaying on the generate PDF. Sometimes the captions are missing, but sometimes they are not (just related to images that don't appear.

TEMPO Nitrogen Dioxide Algorithm Theoretical Basis Document

Access can be granted for those with a production account (if needed). @wrynearson noticed a caching issue the other day, but doesn't seem to help now.

Acceptance Criteria

wrynearson commented 1 month ago

@jjfrench can you think of any reason why this would be happening? cc @frozenhelium.

I have not been able to reproduce this issue – the figures I've tested all download as expected for me.

jjfrench commented 1 month ago

Not entirely sure how these processes work but can we confirm it's a display issue or is the PDF not being generated properly? I can check for logs if I know what to look for (if it's a backend issue)

wrynearson commented 1 month ago

Yes @jjfrench, it's a PDF generation and backend issue. The PDFs are generated using Playwright (see https://github.com/NASA-IMPACT/nasa-apt/issues/622 and referenced issues/PRs for details).

It's strange because the generation is not happening on the user's side, but in the backend. Also, if a document hasn't been changed, we serve a cached version of the generated PDF. I don't understand why document PDFs that @bwbaker1 downloads would be different than the ones that I download, but they appear to be so.