search

NASA-IMPACT / pangeo-notebook-veda-image

Docker container based on pangeo-notebook used on VEDA JupyterHub
https://gallery.ecr.aws/nasa-veda/pangeo-notebook-veda-image
MIT License
0 stars 2 forks source link

Update to pangeo notebook 24.07.02 #12

Open batpad opened 1 month ago

batpad commented 1 month ago

Potentially supercedes https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/pull/11

Trying to update to 24.07.02 to try and maybe, hopefully fix the weird interface issues @jsignell was seeing with 24.06.28 .

cc @sunu

batpad commented 1 month ago

Hmm - I think the test failure here needs some looking at - it seems a bit strange / the order of columns in the output table seem to change, this is the diff output from the failed test at https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/actions/runs/9836267614/job/27151604236 --

  =================================== FAILURES ===================================
  ____________________ notebook: nbregression(test-notebook) _____________________
  pytest_notebook.nb_regression.NBRegressionError: 
  --- expected
  +++ obtained
  ## modified /cells/16/outputs/0/text:
  @@ -1,2 +1,2 @@
   :HoloMap   [time]
  -   :Image   [lon,lat]   (air)
  +   :Image   [lon,lat]   (4xDaily Air temperature at sigma level 995)

  ## modified /cells/18/outputs/0/text:
  @@ -1 +1 @@
  -:Curve   [time]   (air)
  +:Curve   [time]   (4xDaily Air temperature at sigma level 995)

  ## modified /cells/19/outputs/0/text:
  @@ -1,25 +1,26 @@
  -         time   lat    lon         air
  -0  2013-01-31  40.0  285.0  274.552661
  -1  2013-02-28  40.0  285.0  273.603929
  -2  2013-03-31  40.0  285.0  276.138871
  -3  2013-04-30  40.0  285.0  282.911333
  -4  2013-05-31  40.0  285.0  288.135484
  -5  2013-06-30  40.0  285.0  293.957167
  -6  2013-07-31  40.0  285.0  297.506210
  -7  2013-08-31  40.0  285.0  295.102258
  -8  2013-09-30  40.0  285.0  291.740083
  -9  2013-10-31  40.0  285.0  288.149839
  -10 2013-11-30  40.0  285.0  279.911917
  -11 2013-12-31  40.0  285.0  276.186048
  -12 2014-01-31  40.0  285.0  270.596210
  -13 2014-02-28  40.0  285.0  272.124018
  -14 2014-03-31  40.0  285.0  274.704355
  -15 2014-04-30  40.0  285.0  282.099000
  -16 2014-05-31  40.0  285.0  288.787742
  -17 2014-06-30  40.0  285.0  294.042000
  -18 2014-07-31  40.0  285.0  295.739032
  -19 2014-08-31  40.0  285.0  295.084677
  -20 2014-09-30  40.0  285.0  293.141000
  -21 2014-10-31  40.0  285.0  288.132177
  -22 2014-11-30  40.0  285.0  279.517667
  -23 2014-12-31  40.0  285.0  277.252258
  +             lat    lon         air
  +time
  +2013-01-31  40.0  285.0  274.552661
  +2013-02-28  40.0  285.0  273.603929
  +2013-03-31  40.0  285.0  276.138871
  +2013-04-30  40.0  285.0  282.911333
  +2013-05-31  40.0  285.0  288.135484
  +2013-06-30  40.0  285.0  293.957167
  +2013-07-31  40.0  285.0  297.506210
  +2013-08-31  40.0  285.0  295.102258
  +2013-09-30  40.0  285.0  291.740083
  +2013-10-31  40.0  285.0  288.149839
  +2013-11-30  40.0  285.0  279.911917
  +2013-12-31  40.0  285.0  276.186048
  +2014-01-31  40.0  285.0  270.596210
  +2014-02-28  40.0  285.0  272.124018
  +2014-03-31  40.0  285.0  274.704355
  +2014-04-30  40.0  285.0  282.099000
  +2014-05-31  40.0  285.0  288.787742
  +2014-06-30  40.0  285.0  294.042000
  +2014-07-31  40.0  285.0  295.739032
  +2014-08-31  40.0  285.0  295.084677
  +2014-09-30  40.0  285.0  293.141000
  +2014-10-31  40.0  285.0  288.132177
  +2014-11-30  40.0  285.0  279.517667
  +2014-12-31  40.0  285.0  277.252258
jsignell commented 1 month ago

Hmm this is super interesting to see the micro-differences between different versions of libraries. It looks like the independent variable in hvplot is now using a label rather than a name and the range index is removed from the plot data. These changes are all fine and reflect changes in hvplot (and underlying libraries). So I think just rebuilding the output in the notebook should be fine.

batpad commented 1 month ago

So I think just rebuilding the output in the notebook should be fine.

@sunu would you be able to find the time to do this? And when we chat today we can just make sure the docs are updated to do this easily. Thanks!

sunu commented 1 month ago

@batpad I have updated the output in the notebook. And here's a PR that documents the process of rebuilding the output in the notebook: https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/pull/15

batpad commented 1 month ago

Thank you @sunu !

@jsignell you can use this image to test on the hubs: public.ecr.aws/nasa-veda/pangeo-notebook-veda-image:1b9438a4dd6f

jsignell commented 1 month ago

I am still seeing the jittery scroll in jupyter, but it's such a hard thing to reproduce, but I will try to capture a screencast