search

NASA-IMPACT / pangeo-notebook-veda-image

Docker container based on pangeo-notebook used on VEDA JupyterHub
https://gallery.ecr.aws/nasa-veda/pangeo-notebook-veda-image
MIT License
0 stars 2 forks source link

upgrade pangeo-notebook base to 2024-06-02, refs #8 #9

Closed batpad closed 1 month ago

batpad commented 2 months ago

Fixes #8

Updates pangeo-notebook base to 2024-06-02

The Action fails: https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/actions/runs/9609542002/job/26504214731

I think there's two things going on:

I see this error from pip around some dependency resolution:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
  cattrs 23.2.3 requires attrs>=23.1.0, but you have attrs 22.2.0 which is incompatible.

I think we might need to look into that? cc @sunu

The tests "fail", but from a quick eye-balling of the failures, it seems like this should all be expected things after version upgrades - version numbers changing, some changes to JS / CSS, etc.

@jsignell if the test failures all seem kosher and nothing unexpected, we can just probably re-generate the notebook and outputs: https://github.com/NASA-IMPACT/pangeo-notebook-veda-image?tab=readme-ov-file#adding-new-tests - I probably won't get to this today, but if you're unable to get to it, I and @sunu can probably look early next week.

jsignell commented 2 months ago

Nice! I opened #10 which adds some more ignores to the cell metadata. We probably do want to re-evaluate the notebook every now and then, but ideally the tests will be set up so they pass as long as things are still working properly.