NASA-IMPACT / pyQuARC

The pyQuARC tool reads and evaluates metadata records with a focus on the consistency and robustness of the metadata. pyQuARC flags opportunities to improve or add to contextual metadata information in order to help the user connect to relevant data products. pyQuARC also ensures that information common to both the data product and the file-level metadata are consistent and compatible. pyQuARC frees up human evaluators to make more sophisticated assessments such as whether an abstract accurately describes the data and provides the correct contextual information. The base pyQuARC package assesses descriptive metadata used to catalog Earth observation data products and files. As open source software, pyQuARC can be adapted and customized by data providers to allow for quality checks that evolve with their needs, including checking metadata not covered in base package.
Apache License 2.0
19 stars 0 forks source link

DIF 10: DOI Validity Check not working (if applicable) #132

Closed spa0002 closed 2 years ago

spa0002 commented 3 years ago

Describe the bug The DOI validity check for /DIF/Extended_Metadata/Metadata/Value is not working (if applicable).

To Reproduce Steps to reproduce the behavior:

  1. In the the fake dif10 metadata file, change the value provided for /DIF/Extended_Metadata/Value to an invalid DOI url (ex: "https://www.doi.org/10.5067/FAKE/FAKE_L2.061")
  2. Run python main.py --fake FAKE --format dif10

Expected behavior It should output an error for /DIF/Extended_Metadata/Metadata/Value as DOI urls should be valid. Ex: https://www.doi.org/10.5067/FAKE/FAKE_L2.061 is invalid. Provide a valid DOI.

Outputs

Additional context

svbagwell commented 2 years ago

added this field to rule_mapping since I don't see anything in the wiki that says a DOI can't go in this field

svbagwell commented 2 years ago

fixed this issue by updating url_validator.py

svbagwell commented 2 years ago

The edit worked, but now throws an error when a non-DOI element is provided