Closed slesaad closed 2 years ago
why not enums or constants? something like: pyQuARC.FORMATS
?
@xhagrg i was debating between that vs a function; you think that's better? Because i think we had this conversation about version
and we decided to go with a function rather than a constant.
Version is reading from a file, hence a method. These are hard coded, hence a ENUM/constant.
does that matter for the user though since we're exposing it to the users? user doesn't see what's going on behind the hood. we can just as easily make version()
into a constant.
not that i have specific preference, just trying to understand why the preference
version is reading from a file. these lists stored in constants?
LGTM.
Changes proposed
pyQuARC.supported_formats()
get_version()
toversion()
Screenshot