NASA-IMPACT / pyQuARC

The pyQuARC tool reads and evaluates metadata records with a focus on the consistency and robustness of the metadata. pyQuARC flags opportunities to improve or add to contextual metadata information in order to help the user connect to relevant data products. pyQuARC also ensures that information common to both the data product and the file-level metadata are consistent and compatible. pyQuARC frees up human evaluators to make more sophisticated assessments such as whether an abstract accurately describes the data and provides the correct contextual information. The base pyQuARC package assesses descriptive metadata used to catalog Earth observation data products and files. As open source software, pyQuARC can be adapted and customized by data providers to allow for quality checks that evolve with their needs, including checking metadata not covered in base package.

Apache License 2.0

19 stars 0 forks source link

Expose the supported metadata formats #204

Closed slesaad closed 2 years ago

slesaad commented 2 years ago

Changes proposed

Expose supported metadata formats by providing a function pyQuARC.supported_formats()
Rename get_version() to version()

Screenshot

xhagrg commented 2 years ago

why not enums or constants? something like: pyQuARC.FORMATS?

slesaad commented 2 years ago

@xhagrg i was debating between that vs a function; you think that's better? Because i think we had this conversation about version and we decided to go with a function rather than a constant.

xhagrg commented 2 years ago

Version is reading from a file, hence a method. These are hard coded, hence a ENUM/constant.

slesaad commented 2 years ago

does that matter for the user though since we're exposing it to the users? user doesn't see what's going on behind the hood. we can just as easily make version() into a constant.

not that i have specific preference, just trying to understand why the preference

xhagrg commented 2 years ago

version is reading from a file. these lists stored in constants?

xhagrg commented 2 years ago

LGTM.