NASA-IMPACT / pyQuARC

The pyQuARC tool reads and evaluates metadata records with a focus on the consistency and robustness of the metadata. pyQuARC flags opportunities to improve or add to contextual metadata information in order to help the user connect to relevant data products. pyQuARC also ensures that information common to both the data product and the file-level metadata are consistent and compatible. pyQuARC frees up human evaluators to make more sophisticated assessments such as whether an abstract accurately describes the data and provides the correct contextual information. The base pyQuARC package assesses descriptive metadata used to catalog Earth observation data products and files. As open source software, pyQuARC can be adapted and customized by data providers to allow for quality checks that evolve with their needs, including checking metadata not covered in base package.
Apache License 2.0
20 stars 1 forks source link

URL_Check does not catch broken/non-existing links #48

Closed andrewdweis closed 3 years ago

andrewdweis commented 3 years ago

Describe the bug The url_check is flagging any url with the value as True including, for example, this broken links

This bug is occurring for all of the fields the check is applied to:

To Reproduce Steps to reproduce the behavior:

  1. Add a broken link to any of those fields above in the test_cmr_metadata.echo10 file
  2. run the fake record
  3. Notice that a broken link will still give a 'True' value

Expected behavior If a link is a broken link and returns a 404 error or if the site cannot be reached the check should return a value of False and the link that is broken. If the link is functioning is should return True