fix: update condition for setting storage_encrypted

[botanical]

Issue

Link to relevant GitHub issue

What?

• This is the original work https://github.com/NASA-IMPACT/veda-backend/pull/218/files which I'm making slight modifications of since the parameter storage_encrypted is not a part of DatabaseInstanceFromSnapshot, but it is a valid parameter of DatabaseInstance.

Why?

• In testing a test deployment that uses a snapshot, the deployment errors with:

  Traceback (most recent call last):
  File "/home/runner/work/veda-deploy/veda-deploy/veda-backend/app.py", line 66, in <module>
  database = RdsConstruct(
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/jsii/_runtime.py", line 118, in __call__
  inst = super(JSIIMeta, cast(JSIIMeta, cls)).__call__(*args, **kwargs)
  File "/home/runner/work/veda-deploy/veda-deploy/veda-backend/database/infrastructure/construct.py", line 200, in __init__
  database = aws_rds.DatabaseInstanceFromSnapshot(
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/jsii/_runtime.py", line 118, in __call__
  inst = super(JSIIMeta, cast(JSIIMeta, cls)).__call__(*args, **kwargs)
  TypeError: __init__() got an unexpected keyword argument 'storage_encrypted'
  Subprocess exited with error 1

Testing?

• TBD

[anayeaye]

RE Testing?

We will have some evidence that the change is safe for the existing dev and staging stacks in the pr deploy action cdk output which will alert if a change is caused that would require replacing the rds instance (which would appropriately fail if we tried to deploy the update because of our deletion protection setting on the instance). The pre deploy action cdk diff against the dev shows that the change doesn't impact that instance.

The staging stack uses the DatabaseInstanceFromSnapshot construct so we should check that diff on our next dev>main release.

[anayeaye]

@botanical you mentioned updating docs, I think, if anything we could add a line to the database snapshots of our wiki section with the links you gathered in the subject of this PR

[botanical]

@botanical you mentioned updating docs, I think, if anything we could add a line to the database snapshots of our wiki section with the links you gathered in the subject of this PR

Thanks, @anayeaye ! Wiki has been updated https://github.com/NASA-IMPACT/veda-architecture/wiki/DS:-Infrastructure-Maintenance-&-Upgrades#database-snapshots