search

NASA-IMPACT / veda-config

Configuration template for the Dashboard Evolution Project
https://visex.netlify.app/
Other
12 stars 36 forks source link

Story thumbnails have varying height #355

Closed j08lue closed 3 months ago

j08lue commented 9 months ago

We do not enforce a common height on story thumbnails and the published content does not have consistent size / aspect ratio:

image

  1. Does our design intend these story cards to have the same size?
  2. Should we fix them manually?
  3. Or somehow crop them automatically, either during CI or on the page?

Acceptance criteria

aboydnw commented 4 months ago

@j08lue This ticket doesn't seem needed anymore, based on the recent catalog redesign and what I see in the E&A interface. Am I seeing that correctly?

j08lue commented 4 months ago

Good call. Let's see how EarthData Dashboard datasets and layers look in these improved interfaces: https://github.com/NASA-IMPACT/veda-config/pull/360

Varying thumbnail height is indeed not an issue in the new catalog:

image

In the E&A layer overview, it is, though:

image

However, we are planning on changing that layout to use the same layout as the catalog.

So this issue will become obsolete soon. An interim fix would still be welcome - should be a quick fix with ImageMagick or so, perhaps also converting the images to webp in the process...

dzole0311 commented 3 months ago

Closing this since with the new Catalog view now ported to the Dataset Selector modal in E&A in 973, the issue is obsolete.