NASA-IMPACT / veda-config

Configuration template for the Dashboard Evolution Project
https://visex.netlify.app/
Other
18 stars 37 forks source link

add playwright #363

Open stephenkilbourn opened 9 months ago

stephenkilbourn commented 9 months ago

What am I changing and why

This adds a playwright test suite that generates a list of every catalog and story on the /data-catalog and /stories routes. It ensures that the pages render with the name and that there are no javascript errors on those pages. It is dependent on the changes to the `veda-ui located in https://github.com/NASA-IMPACT/veda-ui/pull/835

A follow-up PR can add the github workflow to trigger the test run on each PR once that veda-ui PR is merged. The veda-config will also need a mapbox token added as a github secret.

How to test

run the yarn install to pull in the new dependencies. Run the script yarn test:e2e to verify that the tests run locally.** To verify that tests catch errors, modify pages to break them and ensure that the test suite finds the failure.

** you may be asked to install the playwright browsers on the first run of the test suite.

⚠️ Checks

netlify[bot] commented 9 months ago

Deploy Preview for visex ready!

Name Link
Latest commit 8f76d0234d08c786608956dc39dc978a9cff80b2
Latest deploy log https://app.netlify.com/sites/visex/deploys/66f709a12803bc0008e241ba
Deploy Preview https://deploy-preview-363--visex.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

slesaad commented 1 month ago

@stephenkilbourn is this still relevant? if so, we should merge this

stephenkilbourn commented 1 month ago

@slesaad - I caught this up with the features on develop, so it can be merged in and work after an approving review