search

NASA-IMPACT / veda-config

Configuration template for the Dashboard Evolution Project
https://visex.netlify.app/
Other
12 stars 36 forks source link

[Do not merge] Testing stac-api changes #369

Closed smohiudd closed 6 months ago

smohiudd commented 7 months ago

Testing stac api changes.

Why are you creating this Pull Request?

netlify[bot] commented 7 months ago

Deploy Preview for visex ready!

Name Link
Latest commit 8c9387dbe94633bc2bad21712c7b4b23cd746447
Latest deploy log https://app.netlify.com/sites/visex/deploys/65d4336430403600080f79d2
Deploy Preview https://deploy-preview-369--visex.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hanbyul-here commented 7 months ago

Ah I didn't realize how long we haven't updated veda-ui. I checked why https://github.com/NASA-IMPACT/veda-config/pull/358 (pointing UI v3.0) fails, but this one doesn't.

v3.0 was very strict about the data from the back end. The search on analysis will fail if any of the data is not in the shape we expect. From v4.0, UI loosely checks the data, and if it is not in the shape we expect, UI skips it. In this case, one of the collections (hls-l30-002-ej-reprocessed) has an invalid temporal interval (temporal[1] is null. Is this data from CMR? - if not, any good reason that this is empty? )

smohiudd commented 7 months ago

Thanks @hanbyul-here this explains it. The dev stac catalog is really messy and has some invalid fields - it needs to be cleaned up. The same collection you mentioned in staging doesn't have the null temporal interval: https://staging-stac.delta-backend.com/collections/hls-l30-002-ej-reprocessed.

So in V3.0, if any collection has some invalid metadata relevant to the analysis page, then it doesn't display collections in analysis.

anayeaye commented 7 months ago

@hanbyul-here @smohiudd thanks for the extra info. I'm a little uneasy about the missing upper bounds of the temporal range on in hls-l30-002-ej-reprocessed because it is closed in veda-data and we just updated all of those collections in dev! But also it is good that newer versions of veda-ui do not require closed temporal ranges because the stac-api spec allows unbound ranges

anayeaye commented 6 months ago

Closing this to open a new test backend branch preview #375