NASA-IMPACT / veda-config

Configuration template for the Dashboard Evolution Project
https://visex.netlify.app/
Other
18 stars 37 forks source link

Creating cookie consent feature flag #444

Closed snmln closed 1 month ago

snmln commented 2 months ago

Creating cookie consent feature flag.

The purpose of this change is to allow instances that us the VEDA codebase to toggle on the cookie consent form component at their own discretion.

netlify[bot] commented 2 months ago

Deploy Preview for visex ready!

Name Link
Latest commit cb9e16c06dcfbd2cdebfee1c361966e87c826652
Latest deploy log https://app.netlify.com/sites/visex/deploys/66e987dc43bb8300084d9405
Deploy Preview https://deploy-preview-444--visex.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

slesaad commented 1 month ago

hi @snmln ! i don't see any cookie consent form in the deploy preview 🤔

snmln commented 1 month ago

Hi @slesaad, These changes were originally intended to be paired with some veda-ui changes that have not been merged yet. After having a conversation with @hanbyul-here we also decided to rely on the config values in the veda-ui codebase for the same functionality and are no longer need this ticket.