NASA-IMPACT / veda-data-airflow

Airflow implementation of ingest pipeline for VEDA STAC data
Other
10 stars 4 forks source link

fix: update update_cloudfront resource count conditional #166

Closed botanical closed 5 months ago

botanical commented 5 months ago

Summary: Summary of changes

Addresses VEDA-164: Develop amazing new feature

When trying to deploy with cloudfront_id set, I got this error:

╷
│ Error: Incorrect condition type
│ 
│   on main.tf line 275, in resource "null_resource" "update_cloudfront":
│  275:   count = coalesce(var.cloudfront_id, false) ? 1 : 0
│     ├────────────────
│     │ var.cloudfront_id is "redacted"
│ 
│ The condition expression must be of type bool.
╵

    }

Changes

PR Checklist

botanical commented 5 months ago

Would we prefer the secret name to be CLOUDFRONT_ID or VEDA_CLOUDFRONT_ID?

anayeaye commented 5 months ago

Would we prefer the secret name to be CLOUDFRONT_ID or VEDA_CLOUDFRONT_ID?

In veda-deploy VEDA_ is prefixed to the variables parsed from cdk.out in scripts/generate_env_file.py so I think we should expect VEDA_ in tfvars for now?