Closed abarciauskas-bgse closed 9 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
PR Preview Action v1.4.7
:---:
:rocket: Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-118/
on branch gh-pages
at 2024-02-15 15:20 UTC
@abarciauskas-bgse thanks for catching this! When we moved to multi-assets for collections we removed the automated generation of cog_default min max in summaries because this asset is no longer guaranteed in all collections. When the render metadata are published for this no2-monthly collection, I think we should revisit this notebook to utilize them in the absence of a cog_default summary.
EDIT: also when we update that collection, we'll be fixing the other issues that make the collection invalid. Hopefully that is very soon.
@anayeaye thanks for reviewing - it might be overkill but I wonder if integration tests from https://github.com/NASA-IMPACT/veda-jh-environments/issues/44 could be run whenever there are large STAC metadata changes 🤔
At some point the
no2-monthly
collection lost thecog_default
data from "summaries". This fixes that issue but it may be something that needs to be addressed in the collection itself as well.I found an example of a collection that does have the
cog_default
object in it'ssummaries
object: https://staging-stac.delta-backend.com/collections/ecco-surface-height-change.https://staging-stac.delta-backend.com/collections/no2-monthly has no
cog_default
object in it'ssummaries
.cc @anayeaye