NASA-IMPACT / veda-docs

Documentation for the VEDA Project
https://nasa-impact.github.io/veda-docs
Apache License 2.0
7 stars 7 forks source link

Ab/upgrade 2024.01.23 fixes #119

Closed abarciauskas-bgse closed 8 months ago

abarciauskas-bgse commented 9 months ago

These are 2 minor changes required for 2 notebooks to work once we upgrade to pangeo-notebook base image 2024.01.23 (see https://github.com/NASA-IMPACT/veda-jh-environments/pull/43 and of https://github.com/NASA-IMPACT/veda-jh-environments/pull/42)

  1. timeseries-rioxarray-stackstac.ipynb: I cannot find in the CHANGELOG of stackstac what exactly changed but stackstac went from 0.4.4 to 0.5.0 in the pangeo-notebook image requirements and now requires the epsg to be explicitly passed because it is not set on the STAC items. This line is throwing the error but you can also see it in https://github.com/NASA-IMPACT/veda-docs/commit/a0ae2a261bc5a362094a5789ac361aea541d9731

  2. downsample-zarr.ipynb: Is thworing a ValueError: 'epsg:6933' must be either a valid crs or an reference to adata.attrcontaining a valid crs: Projection must be defined as a EPSG code, proj4 string, WKT string, cartopy CRS, pyproj.Proj, or pyproj.CRS.. As far as I can tell the EPSG:6933 projection is not supported in version 0.9.1 of hvplot whereas it is supported in version 0.8.4. The best thing I can think to do is just specify to use hvplot==0.8.4 for this notebook to continue using that projection. (ref: SMAP L3 Radiometer Global Daily 36 km EASE-Grid Soil Moisture, Version 5)

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 9 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-119/ on branch gh-pages at 2024-02-15 15:41 UTC

jsignell commented 8 months ago

Included in #126

jsignell commented 7 months ago

Just got around to writing up 2. on the hvplot side: https://github.com/holoviz/hvplot/issues/1329 and put up a PR 🤞🏻