Fix biomass notebook: use simpler `rio.clip_box` and remove stackstac workaround

NASA-IMPACT / veda-docs

Documentation for the VEDA Project

https://nasa-impact.github.io/veda-docs

Apache License 2.0

7 stars 7 forks source link

Fix biomass notebook: use simpler `rio.clip_box` and remove stackstac workaround #149

Closed jsignell closed 3 months ago

jsignell commented 4 months ago

The existing rio.clip method was crashing the kernel. I need to investigate more but I am assuming it's some type of aggressive memory issue.

review-notebook-app[bot] commented 4 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 4 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-149/ on branch gh-pages at 2024-08-21 19:44 UTC

wildintellect commented 3 months ago

I agree with the move to bbox filter/clip instead of the polyon aoi. Since we're going that direction, why aren't we deriving the bbox from the Admin boundary to begin with? Suggestion move the ADM download up, use it to make a bbox from the geojson, then also use it for the stats later.

jsignell commented 3 months ago

Ok I moved the boundary download up in the notebook. I'll merge this today unless there are any more suggestions @wildintellect